On Mon, 1 Nov 2004, EECS 382 student wrote: > Prof Wolff, > > > > In doing the take home test I came across some errors in the 8051_opcodes > sheet you handed out and that is posted on the web. You have DPH at x84 and > DPL at x83 where as the 8051 instructions have them at x83 and x82. Also, Thanks. The 8051 Phillips programmer's guide always takes priority and Intel's guide takes priority over everyone: http://bear.ces.cwru.edu/eecs_382/8051_opcodes_philips.pdf > in the handout you have MOV direct8, A as PC++ but it is a two byte > instruction so shouldn't it be PC+=2? Good observation: Yes, if it is a 2 byte instruction it must increment the PC by 2. > These two things are important to the > test so I thought I should bring them to your attention, so if I am right > you could tell the rest of the class. Thankyou. > >